This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
refactor: remove usage of @define #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordOfPolls
added
the
Improvement
silasary
approved these changes
Oct 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
This PR removes usage of the cheat
@definedecorator defined inattr_utils. This change improves type checker and intelisense behaviour across the board. Most got confused with the partial object decloration.Care has been taken to preserve any custom deviation from the normal
@definekwargs.The
@definedefinition itself has been preserved as I am aware downstream project leverage it, however, I'd discourage its usage.Changes
@definein all filesChecklist
Python 3.10.x