This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordOfPolls
added
the
Improvement
Something that is already implemented but can be done better
label
Oct 25, 2022
AlbertUnruh
suggested changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, but you missed these:
NAFF/naff/models/naff/context.py
Lines 526 to 543 in 65538ea
async def edit_origin( | |
self, | |
content: str = None, | |
embeds: Optional[Union[Iterable[Union["Embed", dict]], Union["Embed", dict]]] = None, | |
embed: Optional[Union["Embed", dict]] = None, | |
components: Optional[ | |
Union[ | |
Iterable[Iterable[Union["BaseComponent", dict]]], | |
Iterable[Union["BaseComponent", dict]], | |
"BaseComponent", | |
dict, | |
] | |
] = None, | |
allowed_mentions: Optional[Union["AllowedMentions", dict]] = None, | |
files: Optional[Union[UPLOADABLE_TYPE, Iterable[UPLOADABLE_TYPE]]] = None, | |
file: Optional[UPLOADABLE_TYPE] = None, | |
tts: bool = False, | |
) -> "Message": |
NAFF/naff/models/discord/webhooks.py
Lines 251 to 266 in 65538ea
async def edit_message( | |
self, | |
message: Union["Message", "Snowflake_Type"], | |
content: Optional[str] = None, | |
embeds: Optional[Union[List[Union["Embed", dict]], Union["Embed", dict]]] = None, | |
components: Optional[ | |
Union[List[List[Union["BaseComponent", dict]]], List[Union["BaseComponent", dict]], "BaseComponent", dict] | |
] = None, | |
stickers: Optional[Union[List[Union["Sticker", "Snowflake_Type"]], "Sticker", "Snowflake_Type"]] = None, | |
allowed_mentions: Optional[Union["AllowedMentions", dict]] = None, | |
reply_to: Optional[Union["MessageReference", "Message", dict, "Snowflake_Type"]] = None, | |
files: Optional[Union["UPLOADABLE_TYPE", List["UPLOADABLE_TYPE"]]] = None, | |
file: Optional["UPLOADABLE_TYPE"] = None, | |
tts: bool = False, | |
flags: Optional[Union[int, "MessageFlags"]] = None, | |
) -> Optional["Message"]: |
This might be the most breaking change of 2.x so far :O |
You'd be right, I didn't consider those two - I'll amend them shortly |
AlbertUnruh
approved these changes
Oct 26, 2022
silasary
approved these changes
Oct 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
Makes all edit and send methods use kwargs for most™️ parameters
Changes
As above
Checklist
Python 3.10.x