Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

refactor: remove attribute stacking in guild events #705

Merged
merged 1 commit into from
Oct 30, 2022
Merged

refactor: remove attribute stacking in guild events #705

merged 1 commit into from
Oct 30, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

The new/modified guild events redefined guild when it was already handled by GuildEvent base class. This fixes that

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Improvement Something that is already implemented but can be done better label Oct 29, 2022
@LordOfPolls LordOfPolls merged commit 77cb2b2 into 2.x Oct 30, 2022
@LordOfPolls LordOfPolls deleted the guild_events_fix branch October 30, 2022 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
Improvement Something that is already implemented but can be done better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordOfPolls @silasary