This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
fix💥: Plugin-friendly method of implementing delete_if_overridden
#707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasary
changed the title
delete_if_overriddendelete_if_overridden
LordOfPolls
approved these changes
Oct 29, 2022
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
(Breaking for
2.x, not breaking compared todev)The existing method for unregistering library-provided Listeners introduced in #641 didn't really work well with off-the-shelf extensions, such as Sentry or NaffTrack.
This PR replaces
delete_if_overriddenwith two separate parameters:is_default_listenerfor declaring library-defined listenersoverride_default_listenersfor explicitly wanting to opt-out of the default listener.Checklist
Python 3.10.x