Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix💥: interaction_id should be int... like all other IDs #709

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix💥: interaction_id should be int... like all other IDs #709

merged 1 commit into from
Oct 31, 2022

Conversation

LordOfPolls
Copy link
Member

dammit past polls

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

interaction_id was being stored as str instead of int. This fixes that

Changes

  • Store interaction_id as int
  • Add a converter to achieve the above

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Bug::Library A bug in the library label Oct 31, 2022
@LordOfPolls LordOfPolls merged commit 2461495 into 2.x Oct 31, 2022
@LordOfPolls LordOfPolls deleted the convert-interaction-id branch October 31, 2022 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlbertUnruh AlbertUnruh AlbertUnruh approved these changes

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
Bug::Library A bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LordOfPolls @silasary @AlbertUnruh