Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: check channel_types when syncing #739

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

AstreaTSS
Copy link
Contributor

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change
  • CI change
  • Other: [Replace with a description]

Description

Can you tell I'm trying to finish Astro's rewrite?

Anyways, yeah, channel_types wasn't being checked for syncing, so this fixes that.

Changes

  • Add an entry for channel_types for the options_lookup in _compare_options.

Test Scenario(s)

  • Make a slash command with a channel option type and with a specified channel_type.
  • Sync it, change the channel type, then sync again.
  • Commands are still the same, the logger shows that no commands were overriden.

Checklist

  • I've formatted my code with Black
  • I've added docstrings to everything I've touched
  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x
  • I've tested my changes
  • I've added tests for my code - if applicable
  • I've updated the documentation - if applicable

@LordOfPolls LordOfPolls merged commit cf10687 into NAFTeam:dev Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants