This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
fix: use eq method for ne for SnowflakeObject #743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure objects without an "id" attribute are still correctly compared.
What type of pull request is this?
Description
Trying to compare a
SnowflakeObject
to something else that didn't have anid
attribute via!=
would always error out. This PR fixes that by making__ne__
use__eq__
.Changes
SnowflakeObject.__ne__
return the opposite of__eq__
instead of using custom logic. Honestly, I think you could just remove it altogether, but this was safer.Test Scenario(s)
Just use
SnowflakeObject(SOME_ID) != None
.Checklist
Python 3.10.x
Python 3.11.x