Skip to content
This repository has been archived by the owner on Dec 16, 2019. It is now read-only.

Use Java to generate RSA keys for SSH connection in tests #233

Merged
merged 5 commits into from
Jan 10, 2018
Merged

Use Java to generate RSA keys for SSH connection in tests #233

merged 5 commits into from
Jan 10, 2018

Conversation

dtitov
Copy link

@dtitov dtitov commented Jan 10, 2018

SSHJ library allows generating keys for SSH connection without the need to spawn temporary Docker container.

@dtitov dtitov added this to the Sprint 20 "The X-mas sprint" milestone Jan 10, 2018
@dtitov dtitov self-assigned this Jan 10, 2018
@dtitov dtitov requested a review from silverdaz January 10, 2018 17:35
@silverdaz
Copy link
Contributor

Not calling auxiliary programs.
creating the data directly using java instead.
Maybe a little benefit, maybe not.
But probably better consistency within the tests

@silverdaz silverdaz merged commit a759e85 into dev Jan 10, 2018
@viklund viklund deleted the test/java-rsa branch January 12, 2018 12:09
juhtornr pushed a commit that referenced this pull request May 30, 2018
@silverdaz
Merge pull request #233 from NBISweden/test/java-rsa
8b0c6d9 
Use Java to generate RSA keys for SSH connection in tests
viklund pushed a commit that referenced this pull request Nov 22, 2018
@silverdaz
Merge pull request #233 from NBISweden/test/java-rsa
3798537 
Use Java to generate RSA keys for SSH connection in tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dtitov dtitov

Labels
enhancement
Projects
None yet
Milestone
Sprint 20 "The X-mas sprint"
Development

Successfully merging this pull request may close these issues.
2 participants
@dtitov @silverdaz