This repository has been archived by the owner on Dec 16, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Ditching GnuPG #261
Merged
Merged
Ditching GnuPG #261
Changes from 88 commits
Commits
Show all changes
99 commits
Select commit
Hold shift + click to select a range
cdcdf3c
Parsing a few packets
0dc32f4
This can now decrypt the test file, given a test key and a passphrase.
af2ce2a
Progress on recursion and streaming
b241324
Adding a script entrypoint and moving code around
e6d1b49
Adding cryptography in requirement
ad71776
Fixing the issues with the cleardata buffer
5a39a3c
Using generators. First step towards streaming
625368f
Using generators to process data stream
d96a7b6
Streaming solution for PGP
cf3d017
Updating unlock for private key to only return the material
2349fe1
Updating the consumer generator and changing the loglevel to CRITICAL
b986534
Unlock return 2 bytes object, for the public/private key material
f7e3405
NBISweden/LocalEGA#257 basic keyserver with caching
blankdots c024710
new cache mechanism
blankdots 393f363
NBISweden/LocalEGA#259 caching and unlock request
blankdots cf502e5
NBISweden/LocalEGA#259 check ttl and docker image
blankdots 754049a
NBISweden/LocalEGA#259 fix for ttl
blankdots 214b821
Parsing a few packets
26b89bb
This can now decrypt the test file, given a test key and a passphrase.
7871a73
Progress on recursion and streaming
2ee0337
Adding a script entrypoint and moving code around
cf2fa1a
Adding cryptography in requirement
7454465
Fixing the issues with the cleardata buffer
6b6275a
Using generators. First step towards streaming
c2b6f55
Using generators to process data stream
b7d7eb3
Streaming solution for PGP
c727986
Updating unlock for private key to only return the material
00a014f
Updating the consumer generator and changing the loglevel to CRITICAL
5ca8c89
Unlock return 2 bytes object, for the public/private key material
538fb2c
Adding docstrings documentation
647c445
Updating the gpg_cmd with our python pgp tool
6bb67ee
Merge remote-tracking branch 'origin/feature/pgp-keyserver' into feat…
965b61e
keys back in bootstrap
97dd968
Ditching GnuPG.
bf2fdc5
NBISweden/LocalEGA#259 new keyserver
blankdots 9568df4
NBISweden/LocalEGA#259 fallback, fixed syntax
blankdots bf3ca12
Merge remote-tracking branch 'origin/feature/pgp-ks' into feature/pgp
0ec224f
NBISweden/LocalEGA#259 fix typos and addressing comments
blankdots e6fae2d
Merge remote-tracking branch 'origin/feature/pgp-ks' into feature/pgp
39bc946
Adjusted the ingestion workers with the keyserver routes.
fab8922
Making the ingestion worker ask the PGP private key to the keyserver
9f1994c
Removed the unnecessary entrypoint script for the keyserver.
b013481
Removing the template for frontend and socket proxy/forwarder.
78624a0
Updating the hard-coded value in some tests.
abd182d
Chaning permissions on the PGP public key so that Travis can access it
8640745
No gnupg bin files anymore
1e366fa
cleanup
e848b8d
Making setup.py ALSO (!!!!!) install lega.openpgp
54629ba
Adding more debug output to be logged on the keyserver
e943ad5
Fixing the keyserver port to 443 (https)
b4f1cb0
Catching when the key is not found and making the PGP keyID uppercase…
7cf0736
Reshaping a bit the decrypt code
06e66d1
Removed gnupg folder from the config.properties
e6b1b40
Moving the generate_pgp_key.py away to extras. Normally, we won't nee…
87b1152
Removed a message from the log
36652b3
Moving the generate py.... Fo'Real
a1050f2
No bootstrap image is needed
4202e5e
Updating the inbox with the cache system
e8f9b08
aiohttp is updated so server needed it too
de0cd72
Ditching GnuPG
fe28acb
No fake Cega-MQ. Using the real CentralEGA one.
44107aa
Added a function to generate PGP keys, and generate just calls it
f14ff96
pip install with requirements
49b244e
Removing socket dependency from ega-ingest systemd unit
9588014
psycopg2 version typo
9951881
NBISweden/LocalEGA#259 keyserver adapted to support multiple keys and…
blankdots 7f61510
Misc updates
947b046
NBISweden/LocalEGA#259 fixed typos and refactored to new .conf file; …
blankdots 3b4efef
NBISweden/LocalEGA#259 addressing comments
blankdots a5e0beb
NBISweden/LocalEGA#259 parse Defaults properly
blankdots 12ba3b6
Update on the parser to handle compression packet of given size
cb50971
Merge remote-tracking branch 'origin/feature/pgp-keyserver' into feat…
4ba633e
Adjusting the bootstrap script to match the keyserver endpoints
2837b45
Not using the install_package for pip install git+https://LocalEGA
c3c5389
Moving nc to common
2e02ece
Encrypting with PGPy (instead of GnuPG) a quite small file.
a405e1a
Moving to alpine based image
blankdots 12db24e
Lazy logging
7ba20f3
travis dry run, with debug
blankdots 82dc071
travis dry run install lega module
blankdots 314280c
travis dry run, install package before bootstrap
blankdots e921928
clean up Dockerfiles
blankdots 4504bf9
python3.6 -> python
7eaba81
Merge remote-tracking branch 'origin/feature/pgp-alpine' into feature…
a91c8b5
Making one common image instead of multiple ones
c655000
Timing delay?
3d68a9a
Removing debug code and unbuffered flag
117b4cf
Fixing typos
256a455
Making the keyserver port configurable
f2db3f2
Including review comments from Johan.
cc737ae
Adding a general description for how a packet is structured
d593f3c
Renaming the read_X functions
bd31d95
Bootstrapping back in a container, and not on the host
6307220
Updating some permissions.
240f025
Ingestigating travis issue
a6d6d9a
Making travis user own the private directory
9ad747b
Adding back the fake Message Broker for Central EGA
fd0d6bf
Trying 2 big images (base and inbox) containing everything.
5226e0b
switch back to common
blankdots File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need Python on the "host" machine? Is it for replacing PGP keys generation in bootstrapping from GPG to Python implementation? Do we really need this replacement? I feel like it's redundant because GPG is pre-installed on Ubuntu and we don't need to install anything else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we don't, but here is the issue we fixed with it.
I explain.
We can use GnuPG to generate a key (as we used to do) and export the public key. However, to export the secret key, we need to be at the prompt to type the passphrase. So, that doesn't work for us (and tell me how we could make it work if you know), so we generate the public/private keys in another way (using the PGPy python module).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Isn't that what we need for this to work: https://www.gnupg.org/documentation/manuals/gnupg/Unattended-GPG-key-generation.html ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was exactly what we used to generate the key.
That generates a keyring, and you can export the public from it.
However, to export the secrete key, the passphrase is needed (and prompted).