This repository has been archived by the owner on Dec 16, 2019. It is now read-only.
Adding Eureka Service Discovery to Keyserver #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed java eureka
Conflicts: lega/keyserver.py
silverdaz
reviewed
Mar 16, 2018
| asyncio.TimeoutError) as e: | ||
| LOG.debug(f"Eureka connection error: {e!r}") | ||
| LOG.debug(f"Retrying in {backoff} seconds") | ||
| asyncio.sleep(backoff) |
There was a problem hiding this comment.
Should not this be awaited? (which could be also updated in db.py#L61)
| LOG.error("Could not connect to the Eureka.") | ||
| pass | ||
| # We don't fail right away as we expect the keysever to continue | ||
| # Under "normal deployment" this should exit ? |
There was a problem hiding this comment.
I don't think so.
Probably, it should try again later.
lega/utils/eureka.py
Outdated
| async with aiohttp.ClientSession(headers=self._headers) as session: | ||
| async with session.put(url) as resp: | ||
| LOG.debug('Eureka out_of_service status response %s' % resp.status) | ||
| await session.close() |
There was a problem hiding this comment.
The session is closed already by the context manager (ie, at the end of the with statement)
There was a problem hiding this comment.
I commented them out and tried. It seem to be ok.
silverdaz
approved these changes
Mar 16, 2018
added 3 commits
March 16, 2018 17:35
Moreover, we add [cega-users]/pgp/{username} on the fake cega-users
server, to retrieve the PGP public key of a given user, as if we read
the public key from file.
|
There are now 2 more temporary endpoints:
|
viklund
pushed a commit
that referenced
this pull request
Nov 22, 2018
Adding Eureka Service Discovery to Keyserver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyserver needs to play an extended role, thus we made it register with Eureka Service Discovery.
We don't use a library we instead follow the specification from https://github.com/Netflix/eureka/wiki/Eureka-REST-operations
The keyserver does not fail it there is no connection to Eureka Service discovery.
We provided a fake eureka server just to test that the Keyserver can indeed make the required requests for registration and renewing of lease.
This PR also integrates the RSA key encryption, as we don't want to keep the RSA key unprotected.