Skip to content
This repository has been archived by the owner on Dec 16, 2019. It is now read-only.

Build/Testing Travis Stages #269

Merged
merged 3 commits into from
Mar 31, 2018
Merged

Build/Testing Travis Stages #269

merged 3 commits into from
Mar 31, 2018

Conversation

blankdots
Copy link

Splitting the repositories does not seem to be needed as we can have Travis perform different stages of the build process. Main reason for not performing the split into LocalEGA and LocalEGA-deploy is because there is no easy way to trigger LocalEGA-deploy once the LocalEGA passed all tests and also get the results of the LocalEGA-deploy tests.
Stages:

  1. First stage is run only on a push or PR on Github and it performs using tox python unit tests (there is an added option for flake8 not utilised yet). There are simple unit tests on the keyserver to get things going
  2. Stage 2 is performed only on PR and it runs the Java Test by bootstrapping the LocalEGA docker deployment. The Java (Integration) Tests have been moved under deployment.

@blankdots blankdots requested a review from silverdaz March 29, 2018 12:15
@silverdaz silverdaz added this to the Sprint 26 milestone Mar 31, 2018
@silverdaz
Copy link
Contributor

Looks good to me.
I added a few unit tests for OpenPGP. I doubt tox did anything. But pytest runs fine on its own.

I did not check the PEP8 errors (surprise! 😝).
I think we can add more unit tests later in another PR.
Merging this one.

@silverdaz silverdaz merged commit 72e78a3 into dev Mar 31, 2018
@silverdaz silverdaz deleted the feature/split-deploy branch March 31, 2018 23:17
viklund pushed a commit that referenced this pull request Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants