-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#333: Replaced placeholder with label according to accessibility guid… #455
#333: Replaced placeholder with label according to accessibility guid… #455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding labels makes the gui easier to understand, but some more changes are needed to avoid that the labels pushes the elements out of sight.
…le even in zoomed state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, much better now with the labels and the save button that doesn't disappear when zooming 💯
I'd do some slight change for aesthetic reasons, I think the whole footer should have a bit more space to breathe in the top (mostly visible above the "Add new issue" heading and the "You have unsaved changes" notice). Easiest probably is to give the .footer-container
more top padding.
Also one comment in the code about a similar thing.
And a side note: I personally dislike the bootstrap margin classes because they come with the !important
flag, so they automatically get highest in the CSS priority order, and are hard to understand (what does 1 actually mean in mx-1
- I have to look that up at bootstraps documentation...), but that's a question of personal taste. I think it's fine for now, but we'll have to discuss it for the future.
Why not use normal paddings and margins? is there a benefit on using the bootstrap classes? |
@jonandernovella Yes, I think it's a benefit in using the Bootstrap classes, I've learned to use them as best practice in Bootstrap. The alternative imo is creating more clutter in the code. But I can change it to several css classes np. :) |
Looks nice now. 👍 |
Related issue(s) and PR(s)
This PR closes #333 .
Type of change
List of changes made
Placeholder attribute are not accessible instead there's a recommendation to create a descriptive label instead of the placeholder.
Screenshot of the fix
Definition of Done checklist