Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework focus and blur event handlers #524

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Rework focus and blur event handlers #524

merged 1 commit into from
Aug 1, 2022

Conversation

jonandernovella
Copy link
Contributor

The event handlers now use a arrow fn so that the fns do not fire everytime a component rerenders. Also, now only one row may be selected at a time.

Related issue(s) and PR(s)

This PR closes #523

Type of change

  • Bug fix (non-breaking change which fixes an issue)

List of changes made

  • Event handlers are passed via props using arrow funcs
  • We call the correct fn upon ESC when closing the comment area

Testing

  • Usual procedure

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella jonandernovella requested review from a team and jhagberg July 25, 2022 10:07
@jonandernovella jonandernovella self-assigned this Jul 26, 2022
The event handlers now use a arrow fn so that the fns do not fire everytime a component rerenders. Also, now only one row may be selected at a time.
Copy link
Contributor

@HenrikeW HenrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works!

@HenrikeW HenrikeW merged commit 18984e2 into develop Aug 1, 2022
@HenrikeW HenrikeW deleted the dev/event-fixes branch August 1, 2022 12:51
@jonandernovella jonandernovella mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row highlighting event handlers
2 participants