Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suggestions kbd nav #549

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Fix suggestions kbd nav #549

merged 2 commits into from
Aug 4, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #538

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Prevent default scrolling with up n down arrows

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella jonandernovella changed the title Fix suggestions kdb nav Fix suggestions kbd nav Aug 4, 2022
@jonandernovella jonandernovella requested a review from a team August 4, 2022 11:53
@jonandernovella jonandernovella merged commit 0670f30 into develop Aug 4, 2022
@jonandernovella jonandernovella deleted the dev/scoll branch August 4, 2022 12:07
@jonandernovella jonandernovella mentioned this pull request Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyboard navigation does not work with new search issue function
1 participant
@jonandernovella