Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create reusable tooltip for bar chart #616

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented Aug 31, 2022

Related issue(s) and PR(s)

This PR closes #592.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • a reusable Tooltip component was created, based on what was already used on the favorite rows
  • the tooltip on the favorite rows was replaced by the new component
  • the new component was used to show a tooltip on all sections of the bar chart
  • the styling of the bar chart had to be slightly adjusted to make the tooltip work (replacing overflow: hidden with another border radius)

Screenshot of the fix

image
image

Testing

  • go to the report page and hover over the sections of the bar chart. You should see the tooltip appearing above
  • also try to hover over the favorite rows. You should see the same tooltip as before

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@HenrikeW HenrikeW requested a review from a team August 31, 2022 13:54
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-review only. Looks good. Good idea to create a re-usable component.

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected both on favorites and on the bar chart.

@KattisLej KattisLej merged commit 662b9b3 into develop Aug 31, 2022
@KattisLej KattisLej deleted the dev/barchart-tooltip branch August 31, 2022 15:19
@jonandernovella jonandernovella mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tooltip to horizontal bar
2 participants