Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for user group code #657

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Unit tests for user group code #657

merged 5 commits into from
Sep 21, 2022

Conversation

kusalananda
Copy link
Member

@kusalananda kusalananda commented Sep 16, 2022 •
edited
Loading

Related issue(s) and PR(s)

This PR closes #607

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Unit tests were implemented for the database API to ensure that fetching information related to users and groups is working and so that the correct data is returned in the expected manner.
  • Simple unit tests were implemented for the endpoint API to ensure that the endpoints reply with OK.

Testing

Run the unit tests as usual, from the backend subdirectory:

go test -v ./...

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@kusalananda kusalananda self-assigned this Sep 16, 2022
@kusalananda kusalananda force-pushed the feature/group-unit-tests branch from a453f6a to 2a70c63 Compare September 21, 2022 08:53
@kusalananda kusalananda changed the title First stab at unit tests for database part of user group code (WIP) Unit tests for user group code Sep 21, 2022
@kusalananda kusalananda marked this pull request as ready for review September 21, 2022 09:19
jonandernovella
jonandernovella approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@jonandernovella jonandernovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work as expected.

@jonandernovella jonandernovella merged commit 43e9862 into develop Sep 21, 2022
@jonandernovella jonandernovella deleted the feature/group-unit-tests branch September 21, 2022 13:33
@jonandernovella jonandernovella mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonandernovella jonandernovella jonandernovella approved these changes

Assignees

@kusalananda kusalananda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests for users and groups
2 participants
@kusalananda @jonandernovella