Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytter fetch-implementasjon #1010

Merged
merged 1 commit into from
May 11, 2021

Conversation

gunnarvelle
Copy link
Member

En av sikkerhetsoppdateringene siste dagene var isomorphic-fetch. Denne har en bug som gjør at henting av editors fra auth0 feiler. Basert på kommentarer herfra bytter eg ut til cross-fetch. Det ser ut til å fungere bra.

Test:

  • Lista med editors og ressurstyper skal ha innhold i søket.
  • Alt av eksterne kall skal fungere som før, som grep, youtube, brightcove osv.

@gunnarvelle gunnarvelle requested a review from a team May 11, 2021 08:34
@cypress
Copy link

cypress bot commented May 11, 2021



Test summary

57 0 0 0


Run details

Project editorial-frontend
Status Passed
Commit 8f04950
Started May 11, 2021 8:34 AM
Ended May 11, 2021 8:41 AM
Duration 06:35 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented May 11, 2021



Test summary

57 0 0 0


Run details

Project editorial-frontend
Status Passed
Commit 5ef333c3f0 ℹ️
Started May 11, 2021 8:37 AM
Ended May 11, 2021 8:44 AM
Duration 06:50 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@brdalsnes brdalsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnarvelle gunnarvelle merged commit 9eeae47 into master May 11, 2021
@gunnarvelle gunnarvelle deleted the switch-fetch-to-avoid-bug-in-isomorphic branch May 11, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants