Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

case class for Query Params #34

Closed
theon opened this issue Aug 23, 2013 · 1 comment
Closed

case class for Query Params #34

theon opened this issue Aug 23, 2013 · 1 comment

Comments

@theon
Copy link
Contributor

theon commented Aug 23, 2013

Query Parameters are currently Tuples (String,String).

It would be nice if these were case class to get nicer fields name and value vs _1 and _2.

Still allow Tuples to be passed into methods such as addParam and addParams
@theon
Copy link
Contributor Author

theon commented Feb 23, 2014

On second thoughts I will leave this as Tuples for the meantime and rely on pattern matching

params map { case (name, value) => ... }

and

val (name, value) = param

@theon theon closed this as completed Feb 23, 2014
evanbennett added a commit to evanbennett/scala-uri that referenced this issue Jun 29, 2016
@evanbennett
Implement Path and Uri types.
362193d 
Converted `Uri` to abstract, and created case classes that extend `Uri`
to allow easier validation.
Extracted `Authority` and `UserInfo` classes from the UriParser to be
used fully.
Changed `PathPart` to `Segment`. This is more consistent with the RFC.
Also, "path" and "part" were too similar and being confused.
Changed `QueryString` to `Query`. This is more consistent with the RFC.
Created `Scheme` and `Fragment` classes. This seemed more consistent
with the rest of the structure and eased validation.
Created `Parameter` class. This was mentioned in issue NET-A-PORTER#34 and eased
validation.
Consistency changes throughout.
Deprecated as much as possible to ease transition of existing users.
Started updating the README, not complete.
No DSL changes (aside from compatibility changes) as this will be
completed as a separate task.
@evanbennett evanbennett mentioned this issue Jun 29, 2016
Open
evanbennett added a commit to evanbennett/scala-uri that referenced this issue Jul 7, 2016
@evanbennett
Implement Path and Uri types.
77a10ca 
Converted `Uri` to abstract, and created case classes that extend `Uri`
to allow easier validation.
Extracted `Authority` and `UserInfo` classes from the UriParser to be
used fully.
Changed `PathPart` to `Segment`. This is more consistent with the RFC.
Also, "path" and "part" were too similar and being confused.
Changed `QueryString` to `Query`. This is more consistent with the RFC.
Created `Scheme` and `Fragment` classes. This seemed more consistent
with the rest of the structure and eased validation.
Created `Parameter` class. This was mentioned in issue NET-A-PORTER#34 and eased
validation.
Consistency changes throughout.
Deprecated as much as possible to ease transition of existing users.
Started updating the README, not complete.
No DSL changes (aside from compatibility changes) as this will be
completed as a separate task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theon