Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split README.md file for NLog.Web and NLog.Web.AspNetCore #898

Merged
merged 26 commits into from
Dec 29, 2022

Conversation

bakgerman
Copy link
Contributor

@bakgerman bakgerman commented Nov 30, 2022

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Base: 69% // Head: 69% // Decreases project coverage by -0% ⚠️

Coverage data is based on head (5835cc2) compared to base (a4ea473).
Patch has no changes to coverable lines.

❗ Current head 5835cc2 differs from pull request most recent head b1a0909. Consider uploading reports for the commit b1a0909 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #898   +/-   ##
=====================================
- Coverage      69%    69%   -0%     
=====================================
  Files          66     66           
  Lines        1259   1259           
  Branches      323    323           
=====================================
- Hits          869    866    -3     
- Misses        246    251    +5     
+ Partials      144    142    -2     
Impacted Files Coverage Δ
...utRenderers/AspNetRequestDurationLayoutRenderer.cs 58% <0%> (-7%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snakefoot
Copy link
Contributor

@bakgerman bakgerman changed the title Enable snupkg file. Split README.md file for Web and Web.AspNetCore Split README.md file for Web and Web.AspNetCore Nov 30, 2022
@bakgerman
Copy link
Contributor Author

bakgerman commented Nov 30, 2022

Rolled back the snupkg changes to the csproj files. I will work on the README.MD files as you have suggested. Now that you have given link to proper readme content I think that will be fine.

@bakgerman
Copy link
Contributor Author

Updated the README.MD files as requested

@bakgerman
Copy link
Contributor Author

Is there any other changes that you would like me to perform?

src/NLog.Web/README.md Outdated Show resolved Hide resolved
src/NLog.Web/README.md Outdated Show resolved Hide resolved
@snakefoot
Copy link
Contributor

snakefoot commented Dec 13, 2022

I have no idea what the goal should be for the ReadMe in the nuget-package.

Would it make sense to expand a little on how to get help, besides the link to the basic troubleshooting-guide? Ex. using StackOverflow.com for NLog-related questions, and if wanting to contribute with new ideas / features then one is wellcome to create pull-requests ?

I guess there should also be some introduction about how awesome NLog.Web-extension-package actually is, and how it can solve all problems in the world (sales-pitch presentation)

@bakgerman
Copy link
Contributor Author

Yes, let me ponder that and I will add some additional content regarding the topics mentioned above.

src/NLog.Web/README.md Outdated Show resolved Hide resolved
src/NLog.Web/README.md Outdated Show resolved Hide resolved
src/NLog.Web/README.md Outdated Show resolved Hide resolved
src/NLog.Web/README.md Outdated Show resolved Hide resolved
src/NLog.Web/README.md Outdated Show resolved Hide resolved
src/NLog.Web/README.md Outdated Show resolved Hide resolved
src/NLog.Web/README.md Outdated Show resolved Hide resolved
src/NLog.Web/README.md Outdated Show resolved Hide resolved
@snakefoot
Copy link
Contributor

snakefoot commented Dec 29, 2022

Since README.md will replace current package-description:

Then I think <description> should be updated to this:

Integrates NLog as provider for Microsoft.Extensions.Logging, and provides NLog LayoutRenderers to enrich logging output with details from HttpContext.

Removing "details" about supported platforms.

src/NLog.Web/README.md Outdated Show resolved Hide resolved
@snakefoot
Copy link
Contributor

snakefoot commented Dec 29, 2022

These are my last nit-picks, and then this pull-request be merged right after.

Btw. think the badges looks great.

@bakgerman
Copy link
Contributor Author

Thank you, for the comments.

README.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@snakefoot snakefoot merged commit 30276ad into NLog:master Dec 29, 2022
@snakefoot
Copy link
Contributor

@bakgerman Thank you again for all the hard work.

Thinking about preparing the last NLog-release for this year. Do you have any last code-changes?

@snakefoot snakefoot changed the title Split README.md file for Web and Web.AspNetCore Split README.md file for NLog.Web and NLog.Web.AspNetCore Dec 29, 2022
@bakgerman
Copy link
Contributor Author

No for this year, think health check pull request will be later in January.

@snakefoot
Copy link
Contributor

Nuget-packages are now live:

Think they look good!

@snakefoot snakefoot added this to the 5.2.1 milestone Dec 30, 2022
@bakgerman bakgerman deleted the nuget-enhancements branch December 30, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants