-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split README.md file for NLog.Web and NLog.Web.AspNetCore #898
Conversation
…d LOg.Web.AspNetCore
Codecov ReportBase: 69% // Head: 69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #898 +/- ##
=====================================
- Coverage 69% 69% -0%
=====================================
Files 66 66
Lines 1259 1259
Branches 323 323
=====================================
- Hits 869 866 -3
- Misses 246 251 +5
+ Partials 144 142 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The snupkg-file is already enabled in the build.ps1 I think the ReadMe.md should be very basic (without build-status-links etc.), and should look very similar to this: https://www.nuget.org/packages/NLog.Web.AspNetCore#readme-body-tab Maybe with some links like these: |
Rolled back the snupkg changes to the csproj files. I will work on the README.MD files as you have suggested. Now that you have given link to proper readme content I think that will be fine. |
Updated the README.MD files as requested |
Is there any other changes that you would like me to perform? |
I have no idea what the goal should be for the ReadMe in the nuget-package. Would it make sense to expand a little on how to get help, besides the link to the basic troubleshooting-guide? Ex. using StackOverflow.com for NLog-related questions, and if wanting to contribute with new ideas / features then one is wellcome to create pull-requests ? I guess there should also be some introduction about how awesome NLog.Web-extension-package actually is, and how it can solve all problems in the world (sales-pitch presentation) |
Yes, let me ponder that and I will add some additional content regarding the topics mentioned above. |
Since README.md will replace current package-description: Then I think
Removing "details" about supported platforms. |
These are my last nit-picks, and then this pull-request be merged right after. Btw. think the badges looks great. |
Thank you, for the comments. |
Kudos, SonarCloud Quality Gate passed! |
@bakgerman Thank you again for all the hard work. Thinking about preparing the last NLog-release for this year. Do you have any last code-changes? |
No for this year, think health check pull request will be later in January. |
Nuget-packages are now live:
Think they look good! |
Preview: