This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Model init time selection #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esheehan-gsl
added
the
stacked
Minimum allowed line rate is |
Minimum allowed line rate is |
The frontend is going to need a list of available initialization times to send the correct requests for data.
We need to separate the endpoints for each loop because the loops may have different numbers of observations. So there will need to be another intermediate endpoint responsible for providing URLs that fetch each loop.
I added the /diag/<variable>/<init_time>/ route to handle fetching the available loops. This, coincidentally, took care of the bug with the endpoint that lacked a trailing slash. (Maybe I could've just fixed that without breaking anything…). I had to update the URL for the diag data otherwise it would have conflicted with the list loops endpoint, but the get diag tests are all failing right now because that hasn't actually been implemented.
Now all of the endpoints should be returning diag data just for one loop.
Updated the Svelte components to load the init times for each variable. I decided to replace the model selection (which currently does nothing) with the variable selection, because variable selection (currently) has to happen before we know what init times are available. I think this is backwards and probably needs to change in a future refactor. I updated the app to fetch each loop separately, since we can't combine loops reliably (because they may have a different number of observations).
esheehan-gsl
force-pushed
the
67-ui-zarr-data
branch
from
847d50f
to
801ec4b
Compare
esheehan-gsl
force-pushed
the
api-zarr-data
branch
from
d98e22e
to
9de3c2d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the application to fetch available model initialization times based on
what's available in a Zarr array and allow users to select the init time they'd
like to see.
This PR is stacked on #147.