generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTX Code Release (PI-3): Enhancements to Replace and Route to support enterprise hydrofabric and new NWPS api capabilities in near-real time #865
Open
taddyb33
wants to merge
26
commits into
NOAA-OWP:ti
Choose a base branch
from
taddyb33:development
base: ti
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* migrating files into repo * adding gitignore * changed identifier to lid to be less ambigious * Delete Source/RnR/tests/test_data/2930769 directory * editing binaries * Delete Source/RnR/tests/test_data/2930769 directory * adding back non-malformed data
…onously (#2) * added aio pika * fixed pika sync bugs and got message passing working * removed old files * linted the code * updating requirements.txt * fixed type hinting for python 3.9 * fixed decoding scope: * removing distribution from github
* integrated t_route into the workflow * adding metadata and postprocessing * full beta of RnR done
…e async framework (#6) * added troute intial state param * integrated compose.yaml changes for new pacakges, and aio error handling * adding ignores * added test exception handling
* added troute intial state param * integrated compose.yaml changes for new pacakges, and aio error handling * adding ignores * added test exception handling * fixed plotting bugs * linted and isort
Co-authored-by: taddyb <[email protected]>
* added logging module for errors * tested assimation * updating tests for logging * added more settings updates
* Frontend plot/R&R data view * Frontend changes - search one LID at a time * Function name change in frontend router * Function name change in frontend router
* started a jupyter notebook for verifying code outputs * adding historical flood events * adding historical data * notebook progress * notebook is done * changed verbiage
* Frontend plot/R&R data view * Frontend comment/documentation cleanup * API comment/documentation cleanup
* added readme and cleaned requirements * linted
* added readme and cleaned requirements * linted * updating docs * added publish.md * added rabbit mq docs * added post processing docs * added the last of the docs/ files * added the rest of the README.mds * updated compose
Edit: added note about front-end services and how the majority of code insertions are bootstrap css files |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FIM-S team at RTX has been diligently working on enhancements to the existing Github solutions. This PR is the delivery of said enhancements, and documentation, for OWP approval. In short, the following enhancements were made:
Below we will go into more details of our changes:
Figure 1: A diagram of the new RTX RnR ArchitectureAdditions
Changed the RnR architecture to be an event-driven API
docker compose
/api/v1/publish/start
endpoint fromlocalhost:8000/docs
or through a CURL commandAdded IaC to call RnR through docker compose and syncs outputs to an S3 bucket
Source/RnR/terraform/README.md
for the full docsAdded T-Route as a service
docker pull ghcr.io/taddyb33/t-route-dev:0.0.2
Created a new Hfsubset tool for generating slices of v20.1 of the enterprise hydrofabric
docker pull ghcr.io/taddyb33/hfsubset-legacy:0.0.4
Added a mock database to locally test Replace and Route without the need for a production server
docker pull ghcr.io/taddyb33/hydrovis/mock_database:0.0.1
Added jupyter notebooks to view historical RnR runs and verify correctness
Source/RnR/notebooks/test_historical_LID.ipynb
Created a front-end service to view netcdf files and plots for successful RnR runs on RFC points.
Added a full
docs/
suite to ensure code is documentedAdded docstrings to functions and type hints to ensure code is readable and can be followed
Removals
Changes
owp-viz-replace-route-tar.gzip
file has been moved toSource/RnR/nwm_3.0/
to ensure no code is lostTesting
PyTests were generated for the following tests in the
Source/RnR/tests
folder and can be run usingpytest -s
from theSource/RnR
folder:These tests can be run either while
docker compose
is running, or if it is dead.Screenshots
Figure 2: A geospatial plot of where flow is (green) and where flow is not (grey) between two RFC points on the v20.1 enterprise hydrofabricNotes
Checklist
Testing checklist
Target Environment support
Accessibility
Other