ajk/cfe modifications #448
Conversation
…ables to zero if not provided by other BMIs.
| @@ -46,27 +46,61 @@ | |||
| "cat-27": { | |||
| "formulations": [ | |||
| { | |||
| "name": "bmi_c", | |||
| "name": "bmi_multi", | |||
There was a problem hiding this comment.
Oooh, tricky... this file exists I think to give an example of a bmi_c formulation... but essentially CFE can't now run by itself with existing forcings.... so it has to exist in _multi ... can we make an example using exclusively libpetbmi instead? @hellkite500 ?
There was a problem hiding this comment.
I see what you mean, yes we can't run cfe by itself (as a standalone bmi_c) within the framework anymore and we will need an example of bmi_c formulation, could be PET or noah-owp-mod
There was a problem hiding this comment.
Talked to the group this morning and we will probably just file a TODO to move these examples to the test modules, e.g. extern/test_bmi_c.
| @@ -46,27 +46,61 @@ | |||
| "cat-27": { | |||
| "formulations": [ | |||
| { | |||
| "name": "bmi_c", | |||
| "name": "bmi_multi", | |||
There was a problem hiding this comment.
Same as above.... one way or another though, this file can actually be removed since #430.
There was a problem hiding this comment.
Similar to the above comment, we should have the same TODO clean up this file and make the other one OS-agnostic.
|
@ajkhattak: @donaldwj is going to have a quick look for any impacts to the CFE update that might not show up in the tests and after that we will merge. |
|
sounds good to me. @rlmcdaniel and I have also done detailed testing to make sure cfe base functionality is not impacted. |
|
#453 opened to address any further action here. Cursory review of the model changes does not raise any concerns. Merging. |
The PR updates a few realization files to include SLoTH bmi that is now needed to run cfe in the ngen framework due to recent changes made to cfe. The PR does not change any existing functionality so No changes to the source code and results are consistent with that of the master branch.
Additions
Removals
Changes
Testing
Checklist