Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing test_routing_pybind workflow failures #528

Merged
merged 2 commits into from
May 17, 2023

Conversation

mattw-nws
Copy link
Contributor

@mattw-nws mattw-nws commented May 17, 2023

See comment in #519 and discussion in #524 , rolls back some changes in 7550dfc to fix failing tests, and excludes pyarrow 12.0.0 because of apache/arrow#15054 (v11.0.0 doesn't have the behavior and hopefully 13.0.0 will fix it).

Additions

Removals

Changes

  • rolled back pathing changes in 7550dfc in ngen_routing_config_unit_test.yaml
  • updated workflow YAML to exclude pyarrow version 12.0.0 specifically

Testing

Screenshots

Notes

Todos

  • Make sure when pyarrow 13.0.0 is released that the segfault bug goes away.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux
  • macOS

@mattw-nws mattw-nws changed the title Attempt at fixing test workflow failures Fixing test_routing_pybind workflow failures May 17, 2023
Copy link
Contributor

@program-- program-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

I think this brings up something we need to account for when dealing with config files -- if ngen is available via PATH, then we may want to handle configuration paths as relative to the configuration file (as opposed to relative to the user's cwd, if it does exhibit this behavior), or at least document a defined behavior (if it is not documented already paths being relative to the executable is documented here), but that's for a different discussion :)

@mattw-nws
Copy link
Contributor Author

Yes, it would be particularly nice for configuration files with paths in them to be able to handle paths as relative to the parent file--in this case you'd have to file that issue with NOAA-OWP/t-route 😄 . Interestingly, however, we also generate realization config "files" as strings in some of our tests... so that becomes an edge case that would add some complexity.

@mattw-nws mattw-nws merged commit 315ea05 into NOAA-OWP:master May 17, 2023
@mattw-nws mattw-nws mentioned this pull request Jun 23, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants