Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Scenario languages not shown correctly because of missing data in .ini file #1485

Closed
Quantumrunner opened this issue Apr 11, 2021 · 2 comments
Assignees
Labels
bug To be tested Dev is done, it should now be tested

Comments

@Quantumrunner
Copy link
Collaborator

Describe the bug

After adding the localization.spanish.txt to one of my scenarios and adding the line to the quest.ini the translations are not being added to the .ini file when creating the package. All other translations are missing as well.

When opening the mission the translation works fine. Only the entries for the ini files are missing for all languages

When I switch the valkyrie UI language to german it also adds german data to ini:

name.English=City of the Dead (V1.3)
name.German=Die Stadt der Toten (V1.3)
synopsys.English=When you return to your hometown Vynelvale you find it under siege by undead forces.
synopsys.German=Als ihr in eure Heimatstadt Vynelvale zurückkehrt, findet ihr sie unter Belagerung durch untote Horden.

Same for valkyrie UI spanish:

name.English=City of the Dead (V1.3)
name.Spanish=La ciudad de los muertos (V1.3)
synopsys.English=When you return to your hometown Vynelvale you find it under siege by undead forces.
synopsys.Spanish=Cuando regresáis a vuestra ciudad natal, Vynelvale, descubrís que está siendo asediada por huestes de no muertos.

But the other language is always missing

Demo scenario to reproduce

TranslationError.zip

Valkyrie Version

2.5.4

Desktop

  • OS: Windows 10
@vidimus
Copy link
Contributor

vidimus commented Apr 11, 2021

I downgraded Valkyrie and I was able to create the package without problems. So it's something with the new version. The 2.5.4.a gave me the same problem.

@mayjak mayjak self-assigned this Apr 21, 2021
@mayjak mayjak added the To be tested Dev is done, it should now be tested label Apr 21, 2021
mayjak added a commit that referenced this issue Apr 22, 2021
* fixed loading/exporting translations
* 2.5.5a version bump
@Quantumrunner
Copy link
Collaborator Author

Confirmed fixed with Valkyrie 2.5.5 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug To be tested Dev is done, it should now be tested
Projects
None yet
Development

No branches or pull requests

3 participants