make geometric work again #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -248,7 +248,7 @@ function update_decision_state!( | |||
| return | |||
| end | |||
|
|
|||
| function _get_time_to_recover(event::PSY.GeometricDistributionForcedOutage) | |||
| function _get_time_to_recover(event::PSY.GeometricDistributionForcedOutage, simulation_time, length) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function _get_time_to_recover(event::PSY.GeometricDistributionForcedOutage, simulation_time, length) | |
| function _get_time_to_recover( | |
| event::PSY.GeometricDistributionForcedOutage, | |
| simulation_time, | |
| length, | |
| ) |
| len = state_length, | ||
| ) | ||
| return # do the math on the vals difference | ||
| next_outage_start = findfirst(isequal(1.0), vals) | ||
| next_outage_length = findfirst(isequal(0.0), vals[next_outage_start:end]) - 1 |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| next_outage_length = findfirst(isequal(0.0), vals[next_outage_start:end]) - 1 | |
| next_outage_length = findfirst(isequal(0.0), vals[next_outage_start:end]) - 1 |
Comment on lines
+305
to
+306
| state_length = length(state_timestamps) - state_data_index | ||
| mttr = _get_time_to_recover(event, simulation_time, state_length) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| state_length = length(state_timestamps) - state_data_index | |
| mttr = _get_time_to_recover(event, simulation_time, state_length) | |
| state_length = length(state_timestamps) - state_data_index | |
| mttr = _get_time_to_recover(event, simulation_time, state_length) |
| off_time_step_count = | ||
| Int(mttr) * resolution_ratio + rem(state_data_index, resolution_ratio) #TODO -check if just removing (-1) is correct. | ||
| Int(mttr) * resolution_ratio + rem(state_data_index, resolution_ratio) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Int(mttr) * resolution_ratio + rem(state_data_index, resolution_ratio) | |
| Int(mttr) * resolution_ratio + rem(state_data_index, resolution_ratio) |
| @@ -567,7 +568,7 @@ | |||
| return | |||
| end | |||
|
|
|||
| function _get_outage_ocurrence(event::PSY.GeometricDistributionForcedOutage, rng) | |||
| function _get_outage_ocurrence(event::PSY.GeometricDistributionForcedOutage, rng, current_time) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function _get_outage_ocurrence(event::PSY.GeometricDistributionForcedOutage, rng, current_time) | |
| function _get_outage_ocurrence( | |
| event::PSY.GeometricDistributionForcedOutage, | |
| rng, | |
| current_time, | |
| ) |
| @@ -623,7 +624,7 @@ | |||
| state::SimulationState, | |||
| key::VariableKey{T, U}, | |||
| column_names::Set{String}, | |||
| ::PSY.GeometricDistributionForcedOutage, | |||
| ::PSY.Outage, | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| ::PSY.Outage, | |
| ::PSY.Outage, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For parallel testing on larger system