Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HVDC Lossless model bug in Copperplate network #1241

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

rodrigomha
Copy link
Contributor

Closes #1227

@rodrigomha rodrigomha requested a review from jd-lara February 7, 2025 18:15
@@ -418,6 +418,47 @@ function add_constraints!(
return
end

function add_constraints!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we doing this? If its copper plate it should be no-opt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we model HVDC lines in different subnetworks right? Copperplate balance for each subnetwork using the ref buses, so we want to model HVDC lines between different subnetworks.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (2c1cb5c) to head (64ecc31).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
- Coverage   77.57%   77.50%   -0.07%     
==========================================
  Files         124      124              
  Lines       13817    13840      +23     
==========================================
+ Hits        10718    10727       +9     
- Misses       3099     3113      +14     
Flag Coverage Δ
unittests 77.50% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/devices_models/devices/AC_branches.jl 61.66% <100.00%> (+0.10%) ⬆️
...c/devices_models/devices/TwoTerminalDC_branches.jl 51.64% <100.00%> (+4.23%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Performance Results

Version Precompile Time
Main 5.996574186
This Branch 5.842004951
Version Build Time
Main-Build Time Precompile 70.757856482
Main-Build Time Postcompile 0.834743808
This Branch-Build Time Precompile 66.701256524
This Branch-Build Time Postcompile 0.84428455
Version Solve Time
Main-Solve Time Precompile 582.791871974
Main-Solve Time Postcompile 538.307724861
This Branch-Solve Time Precompile 446.007512348
This Branch-Solve Time Postcompile 405.972298247

@jd-lara jd-lara self-requested a review February 7, 2025 20:01
@jd-lara jd-lara merged commit cd70b38 into main Feb 7, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants