Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T98 estimate bug fix #100

Merged
merged 3 commits into from
Aug 13, 2024
Merged

T98 estimate bug fix #100

merged 3 commits into from
Aug 13, 2024

Conversation

tobin-ford
Copy link
Collaborator

Describe your changes

Bug fix, t98 estimate was broken because of incorrect keyword argument naming within the temperature calls. (we need to add testing for this)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • What's new changelog has been updated in the docs

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.02%. Comparing base (57cb222) to head (33c5078).

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #100   +/-   ##
============================================
  Coverage        67.02%   67.02%           
============================================
  Files               29       29           
  Lines             2111     2111           
============================================
  Hits              1415     1415           
  Misses             696      696           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-springer martin-springer merged commit 9dc106b into development Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants