Major upgrades #120
Merged
Major upgrades #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if two unique instances are created in the same notebook (i suspect current working dir as well) they will use the same saved information and not be able to have unique data for ex: create foo and add job "A" in the pipline, create bar and add job "B" in the pipline foo.pipeline = bar.pipeline => A = B the pipelines will be shared between class instances. only current soltution is to not declare more than one class in the same file (/directory?!?)
resets scenario.
This is useful because the Scenario object stores its data in local files outside of the python script.
This causes issues when two unique scenario instances are created in the same directory, they appear to be seperate instances to python but share the same data. Changes made to one are reflected in both.
potential: conflict between taking file path vs dataframe in func args.
Expanded geo testing
I got this to work to calculate oxygen ingress through an edge seal.
This is a work in progress tool for modeling oxygen ingress.
I added the diffusion.py file to this.
This will now do the calculation for oxygen ingress into a module through an edge seal and into an encapsulant. This is a 1-D calculation. More to come, but this is a stopping point.
This is a tool to run the 1-D oxygen ingress calculation.
Just fixed a small formatting issue.
This is a Json file for acetic acid permeation parameters.
Just some updates to the background xcel file used to create the Json files.
Creation of an H2O permeation Json file.
I'm deleting this because the oxygen ingress parameters are now in an Oxygen ingress parameter Json file. Just some more organization here.
Improvements and additions in the oxygen ingress parameter Json file.
fixed some formatting.
Fixed a capitalization error.
Fixed formatting.
added pytest for the Xmin and added it on the the test_T98. Removed the PPVGIS dependency.
1-D diffusion calculator
Added a test for Xmin in `test_standards.py` and removed dependency on pvgis.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 63.40% 66.51% +3.11%
==========================================
Files 29 36 +7
Lines 2077 3396 +1319
==========================================
+ Hits 1317 2259 +942
- Misses 760 1137 +377 ☔ View full report in Codecov by Sentry. |
tobin-ford
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
See details of changes in release notes for v0.4.0, v0.4.1, v0.4.2.