Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid modifying LCC with Obj Func Incentives #345

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

adfarth
Copy link
Collaborator

@adfarth adfarth commented Jan 18, 2024

  • We previously had some of the objective function modifiers within the "Cost" equation and some were added on using add_to_expression!( Objective, ...
  • Some, but not all, of these were then subtracted out from the LCC in results/financial.jl
  • This PR reverts to how these modifiers were previously included to avoid modifying Costs (instead using @objective(m, Min, m[:Costs] + m[:ObjectiveIncentives] ))
  • The only objective fn incentive that's still removed from the lcc in results/financial.jl is 0.0001 * value(m[Symbol("MinChargeAdder"*_n)]) since this is contained within the TotalElecBill

@adfarth adfarth linked an issue Jan 18, 2024 that may be closed by this pull request
@adfarth adfarth marked this pull request as ready for review January 18, 2024 04:16
Copy link
Collaborator

@Bill-Becker Bill-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of things:

  1. Did you run the test_with_xpress.jl locally? (Did they pass?)
  2. Thoughts on the "Incentives" part of "ObjectiveIncentives" being confusing with actual incentives like tax/production incentives? Maybe there is a standard terminology in linear programming for this type of thing ("Bias", "Steer", "Influence"...?). If you can't find anything, I'm Ok with keeping "Incentives", but my first reaction was "why is incentives not included in the Costs?.

@adfarth
Copy link
Collaborator Author

adfarth commented Jan 23, 2024

Looks good. A couple of things:

  1. Did you run the test_with_xpress.jl locally? (Did they pass?)
  2. Thoughts on the "Incentives" part of "ObjectiveIncentives" being confusing with actual incentives like tax/production incentives? Maybe there is a standard terminology in linear programming for this type of thing ("Bias", "Steer", "Influence"...?). If you can't find anything, I'm Ok with keeping "Incentives", but my first reaction was "why is incentives not included in the Costs?.

I have now run test_with_xpress.jl locally. One test failed due to the LCC changing with this PR. Fixed in 4271de0.

I changed "ObjectiveIncentives" to "ObjectivePenalties"

@adfarth adfarth merged commit 1b90763 into develop Jan 25, 2024
3 of 4 checks passed
@adfarth adfarth deleted the obj-incentives branch January 25, 2024 00:06
adfarth added a commit that referenced this pull request Feb 7, 2024
Avoid modifying LCC with Obj Func Incentives
indu-manogaran pushed a commit that referenced this pull request Sep 16, 2024
Avoid modifying LCC with Obj Func Incentives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct LCC when soc is added to objective
2 participants