-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid modifying LCC with Obj Func Incentives #345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bill-Becker
reviewed
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple of things:
- Did you run the test_with_xpress.jl locally? (Did they pass?)
- Thoughts on the "Incentives" part of "ObjectiveIncentives" being confusing with actual incentives like tax/production incentives? Maybe there is a standard terminology in linear programming for this type of thing ("Bias", "Steer", "Influence"...?). If you can't find anything, I'm Ok with keeping "Incentives", but my first reaction was "why is incentives not included in the Costs?.
I have now run test_with_xpress.jl locally. One test failed due to the LCC changing with this PR. Fixed in 4271de0. I changed "ObjectiveIncentives" to "ObjectivePenalties" |
Bill-Becker
approved these changes
Jan 25, 2024
adfarth
added a commit
that referenced
this pull request
Feb 7, 2024
Avoid modifying LCC with Obj Func Incentives
indu-manogaran
pushed a commit
that referenced
this pull request
Sep 16, 2024
Avoid modifying LCC with Obj Func Incentives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_to_expression!( Objective, ...
results/financial.jl
Costs
(instead using@objective(m, Min, m[:Costs] + m[:ObjectiveIncentives] )
)results/financial.jl
is0.0001 * value(m[Symbol("MinChargeAdder"*_n)])
since this is contained within theTotalElecBill