Enable solve_for_points() with CC model
#1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misi9170
changed the title
solve_for_points() with CC model
rafmudaf
force-pushed
the
ehmt/enable-points
branch
from
79994d7 to
534f86e
Compare
|
This also fixes places in the CC and TurbOPark solvers where the |
rafmudaf
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1039 (and #1038) by enabling the use of
Core.solve_for_points()with the Cumulative Curl model. In the end, this just amounted to ensuring that inputs to function calls in thefull_flow_cc_solver()had the correct dimensions (4D).With this change implemented, examples/examples_get_flow/002_extract_wind_speed_at_points.py can now be run using the
"cc"model.Functional changes are limited to the
full_flow_cc_solver(). The other place that thefull_flow_cc_solver()is called is inCore.solve_for_viz(). Operation of this does not appear to be affected (as tested by running examples/examples_visualizations/002_visualize_y_cut_plane.py with the"cc"model).