Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width and length conditionals in create_bar #1822

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Oct 4, 2024

Pull request overview

Fixes width and length conditionals in create_bar; they were failing because of trying to subtract from a FALSE conditional.

Pull Request Author

  • Method changes or additions
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified

@mdahlhausen mdahlhausen merged commit 52eda15 into master Oct 6, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/create_bar_width_length_conditionals branch October 6, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant