Bnb/1d nc loading #247
Open
Bnb/1d nc loading #247
+510
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pass chunk shape. For some grid sizes and forward pass chunk shapes not forcing this minimum shape can result in a chunk that is too small for the generator. Fixed slice test, which was not checking all slices.
…tor padding layer requirements.
…cing values (hr_cropped_slices, for example) depend a lot on the pad width implementations so these should be grouped.
bnb32
force-pushed
the
bnb/1d_nc_loading
branch
from
587c375
to
11acb62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some adjustments to loaders so they work nicer with flattened nc data. Also fix for slicer edge case where
modulo(grid_shape, fwp_chunk_shape)is too small for generator padding layer requirements.