Skip to content
This repository has been archived by the owner on Dec 9, 2022. It is now read-only.

Update to conda-forge recipes #258

Closed
wants to merge 3 commits into from
Closed

Conversation

CJ-Wright
Copy link
Collaborator

This was created with the script from #256

Copy link
Contributor

@danielballan danielballan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR was auto-generated but never read. Crucial details have been blown away. Needs careful review before merging.

script: python setup.py install --single-version-externally-managed --record=record.txt
skip: True # [py2k]
number: 0
skip: True # [py2k or osx]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why skip OSX?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis was so behind that it was not worth building on OSX. As things speed up it may get better and I'm more than happy to build on all platforms https://www.traviscistatus.com/

@@ -21,7 +25,6 @@ requirements:
- boltons
- cytoolz
- doct
- glueviz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't delete these optional dependencies from the recipe. They are optional for the package but required on the floor. (We need pymongo, especially.)

- six
- tifffile
- tornado
- tzlocal
- ujson

test:
requires:
- nslsii_dev_configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,30 +1,34 @@
{% set version = "2.7.0" %}
{% set version = "2.7.1" %}
{% set sha256 = "55bdefda47c49973ec24384097d18eb5f84797c057aaf0bf0b6b0f7860ad43e7" %}

package:
name: h5py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attn @tacaswell

@@ -21,12 +20,11 @@ source:
- osx_configure.patch # [osx]

build:
number: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attn @tacaswell


build:
number: 1
script: |
export PYEPICS_LIBCA=$PREFIX/lib/libca.so
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CJ-Wright Why delete this?

@CJ-Wright
Copy link
Collaborator Author

CJ-Wright commented Jan 25, 2018

Yes these were auto generated by copying over conda-forge recipes and not curated. I'd rather not curate them here. Personally I would like to either blacklist packages from the update (bluesky, pyepics) where we expect the conda-forge package to never match the needs of the ring, or fix them on conda-forge. This way we can be self consistent.

@mrakitin mrakitin added this to the nsls-ii-forge milestone Mar 15, 2019
mrakitin pushed a commit to mrakitin/lightsource2-recipes that referenced this pull request Jun 28, 2019
@CJ-Wright CJ-Wright closed this Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants