Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to disable loading default config #7

Closed
aptlin opened this issue Apr 28, 2023 · 4 comments
Closed

Add the option to disable loading default config #7

aptlin opened this issue Apr 28, 2023 · 4 comments
Assignees

Comments

@aptlin
Copy link

aptlin commented Apr 28, 2023

Thanks so much for making this awesome project open-source!
Here is a small pet peeve about the current design: at the moment from_content always loads the default instructions, together with the dir-loading branch offrom_path. Since the default config is only relevant for NVIDIA, should we make this behavior opt-in?

@drazvan drazvan self-assigned this Apr 28, 2023
@drazvan
Copy link
Collaborator

drazvan commented Apr 28, 2023

Hi @aptlin! The default config is not meant to be NVIDIA-specific. In the default sample conversation, the question "Tell me a bit about the history of NVIDIA" is meant as an example of a general question. It could have been "Who invented the internet?" or anything else. Did you notice any unintended behaviour because of that?

Currently, without a sample conversation, the LLM will not perform as well in predicting the canonical forms for user and bot messages. That's why there's the option to override it, by specifying your own, or use the default one. But not remove it completely.

@aptlin
Copy link
Author

aptlin commented Apr 28, 2023

Makes sense, thanks! Not sure if it gets overriden though in the cases I've listed above, because _join_config just appends the instructions.

@drazvan
Copy link
Collaborator

drazvan commented Apr 28, 2023

Indeed, you are right. It does not get overridden. Will push a fix shortly. Thanks for catching this!

@drazvan
Copy link
Collaborator

drazvan commented Apr 28, 2023

Should be fixed now. Will be included in the next release. Thanks again!

@drazvan drazvan closed this as completed Apr 28, 2023
drazvan pushed a commit that referenced this issue Jun 5, 2024
Some changes is sample flows.co
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants