-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option to disable loading default config #7
Comments
Hi @aptlin! The default config is not meant to be NVIDIA-specific. In the default sample conversation, the question "Tell me a bit about the history of NVIDIA" is meant as an example of a general question. It could have been "Who invented the internet?" or anything else. Did you notice any unintended behaviour because of that? Currently, without a sample conversation, the LLM will not perform as well in predicting the canonical forms for user and bot messages. That's why there's the option to override it, by specifying your own, or use the default one. But not remove it completely. |
Makes sense, thanks! Not sure if it gets overriden though in the cases I've listed above, because |
Indeed, you are right. It does not get overridden. Will push a fix shortly. Thanks for catching this! |
Should be fixed now. Will be included in the next release. Thanks again! |
Thanks so much for making this awesome project open-source!
Here is a small pet peeve about the current design: at the moment
from_content
always loads the default instructions, together with the dir-loading branch offrom_path
. Since the default config is only relevant for NVIDIA, should we make this behavior opt-in?The text was updated successfully, but these errors were encountered: