Adds configurable stop tokens #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zander Mackie <[email protected]>
Signed-off-by: Zander Mackie <[email protected]>
zmackie
force-pushed
the
zmackie/add-stop-config
branch
from
1bed40a to
13c04d6
Compare
drazvan
reviewed
Feb 1, 2024
|
@drazvan I believe this should do it. I wasn't totally sure about the use of stops in generation tasks, but I guessed this wasn't useful. LMK what you think. Happy to update documentation, etc. if that's important. |
|
Let's merge this. I'll add the documentation in a separate commit. |
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial start of #224
I wanted to open this PR to make sure the maintainers were okay with the direction.
stopis sort of an odd parameter that doesn't have an obvious place to live (from what I saw...very well could be wrong).Thanks!