[In Progress]Add poetry to build and manage package #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drazvan Should I proceed with this? |
|
Thanks for starting this @pranjaldoshi96! Yes, after the 0.2.0 release (today/tomorrow), we'll migrate to poetry as well. It was on my TODO list. On a different note, as per our Contribution policy, all commits must be signed (https://github.com/NVIDIA/NeMo-Guardrails/blob/main/CONTRIBUTING.md#signing-your-work). Make sure your commit(s) are signed and force push the branch again. Thanks! |
Signed-off-by: Pranjal Doshi <[email protected]>
pranjaldoshi96
force-pushed
the
feature/poetry-package-manager
branch
from
f308819 to
2203d7c
Compare
|
In #240 we made the migration to |
drazvan
added
duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim is to use poetry instead of setup.py to build and manage package. As most of the packages are now moving towards poetry.