Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve chat cli logging #603

Merged
merged 12 commits into from
Jul 5, 2024
Merged

Conversation

schuellc-nvidia
Copy link
Collaborator

  • Improves the NG chat CLI visualization, making it more compact and easier to distinguish between logs (in verbose mode) and the user bot interaction.
  • Adds default log statements to the CSL to improve debuggability
  • Fixes some related bugs

@schuellc-nvidia schuellc-nvidia self-assigned this Jul 4, 2024
@drazvan drazvan self-requested a review July 5, 2024 08:11
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I activated back the spinner (you can't use print with end="" when the spinner is active, but that was easy to fix). It's a nicer experience with the spinner, especially when you're not in verbose mode.

@drazvan drazvan merged commit 5e9163d into develop Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants