Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jared/v2 main/nvidia styles #101

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Jared/v2 main/nvidia styles #101

merged 6 commits into from
Aug 15, 2024

Conversation

jwilber
Copy link
Collaborator

@jwilber jwilber commented Aug 15, 2024

Adds the following to the documentation:

  • Nvidia fonts
  • Nvidia colors
  • Light + dark theme and toggle
  • Nvidia images and favicon
  • Copyright mention at bottom

Default theme (non-NVIDIA colors/fonts):

Screenshot 2024-08-14 at 5 21 58 PM

Light Theme with NVIDIA colors/fonts:

Screenshot 2024-08-14 at 5 15 39 PM

Dark Theme with NVIDIA colors/fonts:

Screenshot 2024-08-14 at 5 15 31 PM

@jwilber jwilber self-assigned this Aug 15, 2024
@jwilber
Copy link
Collaborator Author

jwilber commented Aug 15, 2024

/build-ci

Copy link
Collaborator

@jstjohn jstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the green. Shipit

@jwilber
Copy link
Collaborator Author

jwilber commented Aug 15, 2024

/build-ci

1 similar comment
@pstjohn
Copy link
Collaborator

pstjohn commented Aug 15, 2024

/build-ci

Copy link
Collaborator

@pstjohn pstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that dark theme isn't quite there yet... but otherwise looks great! thanks!

docs/README.md Outdated Show resolved Hide resolved
@jwilber
Copy link
Collaborator Author

jwilber commented Aug 15, 2024

Yeah that dark theme isn't quite there yet... but otherwise looks great! thanks!

@pstjohn I agree, I think some better code-highlighting will help, but yes let's improve it at some point :D

@pstjohn
Copy link
Collaborator

pstjohn commented Aug 15, 2024

/build-ci

@pstjohn
Copy link
Collaborator

pstjohn commented Aug 15, 2024

IMO this might be a better style inspiration for light / dark mode, although I don't have too strong an opinion

Light:
Screenshot 2024-08-15 at 9 25 32 AM

Dark:
Screenshot 2024-08-15 at 9 26 09 AM

i.e., black header with white text, green logo, green accent text in both light / dark mode

@jwilber jwilber merged commit f0050f3 into v2-main Aug 15, 2024
3 checks passed
@jwilber
Copy link
Collaborator Author

jwilber commented Aug 16, 2024

(testing, unrelated to this merged PR) /build-ci

@pstjohn pstjohn deleted the jared/v2-main/nvidia-styles branch January 17, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants