Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing secuirty scan vulnerabilities #104

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fixing secuirty scan vulnerabilities #104

merged 2 commits into from
Aug 20, 2024

Conversation

ohadmo
Copy link
Member

@ohadmo ohadmo commented Aug 19, 2024

No description provided.

@ohadmo ohadmo requested review from jstjohn and trvachov August 19, 2024 18:52
@ohadmo ohadmo self-assigned this Aug 19, 2024
@ohadmo
Copy link
Member Author

ohadmo commented Aug 19, 2024

/build-ci

@ohadmo ohadmo force-pushed the omosafi/security-scan branch from cdc89cb to ebd039b Compare August 19, 2024 21:58
@ohadmo
Copy link
Member Author

ohadmo commented Aug 19, 2024

/build-ci

1 similar comment
@ohadmo
Copy link
Member Author

ohadmo commented Aug 20, 2024

/build-ci

@ohadmo
Copy link
Member Author

ohadmo commented Aug 20, 2024

/build-ci

Copy link
Collaborator

@jstjohn jstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also @malcolmgreaves note that we ned to remove infra-bionemo. Can we prioritize getting the scripts we want from your repo moved in?

@ohadmo ohadmo merged commit 33ffda3 into v2-main Aug 20, 2024
3 checks passed
@malcolmgreaves
Copy link
Collaborator

malcolmgreaves commented Aug 20, 2024

What do you mean "we need to remove infra-bionemo?" I don't see infra-bionemo mentioned in this PR -- can you point me to the relevant part?

@malcolmgreaves
Copy link
Collaborator

Also @ohadmo @trvachov what bionemo sub-package are these dependencies supposed to be for? These are added to the image but not to any sub-package. So they won't be present when the packages are built and published.

@ohadmo ohadmo deleted the omosafi/security-scan branch October 4, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants