-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jwilber/load nb from subpackages #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilber
requested review from
jomitchellnv,
jstjohn,
malcolmgreaves,
skothenhill-nv and
pstjohn
as code owners
August 30, 2024 20:50
malcolmgreaves
approved these changes
Aug 30, 2024
pstjohn
reviewed
Aug 30, 2024
pstjohn
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up gen_ref_pages.py
! As discussed via slack, I think this should be pretty easy to merge with my edits in #120
jstjohn
approved these changes
Aug 31, 2024
jwilber
force-pushed
the
jwilber/load-nb-from-subpackages
branch
from
September 3, 2024 23:43
f92bb26
to
f1d4947
Compare
/build-ci |
pstjohn
added a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automates/outlines the pulling of
sub-package
-specific content.What we pull/how we structure the sub-packages is subject to change, but this outlines pulling:
Developer guide
tab.Examples
tab.I expect be adding/editing automation utilities in some capacity, so I refactored the script into file-specific utility funcs, so it's easier to follow.
Below is what gets generated (again, subject to change on how this looks eventually):
Developer guide
README
s are loaded as the main documentation entry point, for each sub-package (the tab name is the README's first header).Examples:
Notebooks for each sub-package. This assumes that each sub-package stores them in a dir,
examples/
.