-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation covering megatron and code structure rationalle #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstjohn
requested review from
dorotat-nv,
malcolmgreaves,
jomitchellnv and
pstjohn
as code owners
September 11, 2024 00:01
jstjohn
changed the title
Add documentation covering megatron and a few extra tidbits to index
Add documentation covering megatron and code structure rationalle
Sep 11, 2024
jstjohn
commented
Sep 11, 2024
pstjohn
approved these changes
Sep 16, 2024
/build-ci |
jwilber
reviewed
Sep 17, 2024
jwilber
reviewed
Sep 17, 2024
jwilber
reviewed
Sep 17, 2024
jwilber
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some small comments, looks good!
(We'll need to make sure we complete the TODO Someone with more experience than
part before release :) )
jstjohn
force-pushed
the
jstjohn/overview_documentation_1
branch
from
September 17, 2024 20:52
214644a
to
95959dc
Compare
jstjohn
force-pushed
the
jstjohn/overview_documentation_1
branch
from
September 17, 2024 22:10
95959dc
to
37c2914
Compare
/build-ci |
/build-ci |
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.