Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation covering megatron and code structure rationalle #153

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

jstjohn
Copy link
Collaborator

@jstjohn jstjohn commented Sep 11, 2024

No description provided.

@jstjohn jstjohn self-assigned this Sep 11, 2024
@jstjohn jstjohn changed the title Add documentation covering megatron and a few extra tidbits to index Add documentation covering megatron and code structure rationalle Sep 11, 2024
docs/docs/user-guide/nemo2.md Outdated Show resolved Hide resolved
docs/docs/user-guide/nemo2.md Outdated Show resolved Hide resolved
docs/docs/user-guide/nemo2.md Show resolved Hide resolved
docs/docs/user-guide/nemo2.md Outdated Show resolved Hide resolved
docs/docs/user-guide/nemo2.md Outdated Show resolved Hide resolved
docs/docs/user-guide/nemo2.md Show resolved Hide resolved
@dorotat-nv dorotat-nv changed the base branch from v2-main to main September 16, 2024 19:35
@dorotat-nv
Copy link
Collaborator

/build-ci

@jstjohn jstjohn requested a review from jwilber September 16, 2024 22:29
Copy link
Collaborator

@jwilber jwilber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small comments, looks good!
(We'll need to make sure we complete the TODO Someone with more experience than part before release :) )

@jstjohn jstjohn force-pushed the jstjohn/overview_documentation_1 branch from 95959dc to 37c2914 Compare September 17, 2024 22:10
@jstjohn
Copy link
Collaborator Author

jstjohn commented Sep 17, 2024

/build-ci

@jstjohn jstjohn enabled auto-merge (squash) September 17, 2024 22:11
@jstjohn
Copy link
Collaborator Author

jstjohn commented Sep 17, 2024

/build-ci

@jstjohn
Copy link
Collaborator Author

jstjohn commented Sep 17, 2024

/build-ci

@jstjohn jstjohn merged commit 17c7f62 into main Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants