Add a tested function to see if model parallel is enabled #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstjohn
requested review from
farhadrgh,
dorotat-nv,
gwarmstrong,
jomitchellnv,
malcolmgreaves,
pstjohn and
skothenhill-nv
as code owners
jstjohn
commented
Sep 19, 2024
sub-packages/bionemo-testing/src/bionemo/testing/megatron_parallel_state_utils.py
Outdated
Show resolved
Hide resolved
pstjohn
reviewed
Sep 19, 2024
sub-packages/bionemo-llm/tests/bionemo/llm/utils/test_megatron_utils.py
Outdated
Show resolved
Hide resolved
|
/build-ci |
|
/build-ci |
|
/build-ci |
pstjohn
approved these changes
Sep 19, 2024
sub-packages/bionemo-llm/src/bionemo/llm/utils/megatron_utils.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-llm/src/bionemo/llm/utils/megatron_utils.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-testing/src/bionemo/testing/megatron_parallel_state_utils.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-testing/src/bionemo/testing/megatron_parallel_state_utils.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-testing/src/bionemo/testing/megatron_parallel_state_utils.py
Show resolved
Hide resolved
sub-packages/bionemo-testing/tests/bionemo/testing/test_megatron_parallel_state_utils.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter St. John <[email protected]> Signed-off-by: John St. John <[email protected]>
Co-authored-by: Peter St. John <[email protected]> Signed-off-by: John St. John <[email protected]>
|
/build-ci |
|
/build-ci |
1 similar comment
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A utility function to test if model parallelism settings beyond DP are enabled.
In addition, this PR adds testing utility functions to mock a megatron parallel cluster.