Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wandb integration #205

Merged
merged 12 commits into from
Oct 2, 2024
Merged

Wandb integration #205

merged 12 commits into from
Oct 2, 2024

Conversation

olachinkei
Copy link
Collaborator

@olachinkei olachinkei commented Sep 27, 2024

Hi @jstjohn
Please review my PR and test this instead of me (sorry for the inconvenience)

Summary

High level summary of changes. Try to keep this as short and informative as possible: less is more.

  • Add wandb integration

Details

Describe your changes. You can be more detailed and descriptive here.

  • Added more wandb arguments so that wandb users can user wandb more flexibly (such as resume)

Usage

How does a user interact with the changed code?

TEST_DATA_DIR=$(bionemo_test_data_path single_cell/testdata-20240506 --source pbss); \
python  \
    scripts/singlecell/geneformer/train.py     \
    --data-dir ${TEST_DATA_DIR}/cellxgene_2023-12-15_small/processed_data    \
    --result-dir ./results     \
    --experiment-name test_experiment     \
    --num-gpus 1  \
    --num-nodes 1 \
    --val-check-interval 10 \
    --num-dataset-workers 0 \
    --num-steps 55 \
    --seq-length 128 \
    --limit-val-batches 2 \
    --micro-batch-size 2 \
    --wandb_entity: <your entity> \
    --wandb_project: "test-project" \
    --wandb_tags: "test" \
    --wandb_log_model

After running the first run, please test resume function with the following command

TEST_DATA_DIR=$(bionemo_test_data_path single_cell/testdata-20240506 --source pbss); \
python  \
    scripts/singlecell/geneformer/train.py     \
    --data-dir ${TEST_DATA_DIR}/cellxgene_2023-12-15_small/processed_data    \
    --result-dir ./results     \
    --experiment-name test_experiment     \
    --num-gpus 1  \
    --num-nodes 1 \
    --val-check-interval 10 \
    --num-dataset-workers 0 \
    --num-steps 55 \
    --seq-length 128 \
    --limit-val-batches 2 \
    --micro-batch-size 2 \
    --wandb_entity <your entity> \
    --wandb_project test-project \
    --wandb_tags test \
    --wandb_id <first run_id> \
    --wandb_log_model

@jstjohn
Copy link
Collaborator

jstjohn commented Sep 28, 2024

/build-ci

@jstjohn
Copy link
Collaborator

jstjohn commented Sep 28, 2024

@olachinkei Sorry Kei, I did not get a chance to run this test today but I did just kick off our CI on this PR so we can see how that does.

@olachinkei
Copy link
Collaborator Author

Thank you, @jstjohn !
Just to confirm the next steps, is it now my turn to take action? Or should I wait for you to run it?

@jstjohn jstjohn force-pushed the wandb-integration branch from cad1489 to 54d780a Compare October 2, 2024 17:24
@jstjohn jstjohn force-pushed the wandb-integration branch from 54d780a to a5ef4c1 Compare October 2, 2024 18:37
@jstjohn
Copy link
Collaborator

jstjohn commented Oct 2, 2024

/build-ci

Copy link
Collaborator

@tshimko-nv tshimko-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the increased functionality! Approved.

@jstjohn jstjohn enabled auto-merge (squash) October 2, 2024 18:45
@jstjohn
Copy link
Collaborator

jstjohn commented Oct 2, 2024

/build-ci

@jstjohn
Copy link
Collaborator

jstjohn commented Oct 2, 2024

/build-ci

@jstjohn
Copy link
Collaborator

jstjohn commented Oct 2, 2024

/build-ci

@jstjohn
Copy link
Collaborator

jstjohn commented Oct 2, 2024

/build-ci

@jstjohn jstjohn merged commit 76001fe into main Oct 2, 2024
3 checks passed
tshimko-nv pushed a commit that referenced this pull request Oct 2, 2024
* add more arguments for wandb integration

* add more arguments to wandblogger

* edit explanation and delete unnecessary variables

* modification

* modification

* recommit

* arrange import parts

* Fix CLI parsing

---------

Co-authored-by: John St John <[email protected]>
@pstjohn pstjohn deleted the wandb-integration branch January 17, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants