add dev tools to devcontainer build #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstjohn
requested review from
dorotat-nv,
jomitchellnv,
malcolmgreaves,
ohadmo and
trvachov
as code owners
pstjohn
force-pushed
the
pstjohn/main/devcontainer-devtools
branch
from
5373dc2 to
4b9cbec
Compare
jstjohn
approved these changes
Sep 30, 2024
pstjohn
force-pushed
the
pstjohn/main/devcontainer-devtools
branch
from
4b9cbec to
6b78e03
Compare
pstjohn
requested review from
skothenhill-nv,
farhadrgh,
gwarmstrong,
DejunL and
guoqing-zhou
as code owners
pstjohn
force-pushed
the
pstjohn/main/devcontainer-devtools
branch
from
6b78e03 to
d53afdf
Compare
pstjohn
changed the title
|
/build-ci |
pstjohn
force-pushed
the
pstjohn/main/devcontainer-devtools
branch
from
d53afdf to
262cc98
Compare
pstjohn
changed the title
sichu2023
approved these changes
Sep 30, 2024
pstjohn
force-pushed
the
pstjohn/main/devcontainer-devtools
branch
from
83fe18b to
0c28961
Compare
|
/build-ci |
dorotat-nv
approved these changes
Sep 30, 2024
tshimko-nv
pushed a commit
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds development tools from
requirements-dev.txtto the devcontainer image.This also reverts #123 since it seems to have introduced some import errors