-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install geometric dependencies before invalidating caches with source copy #224
Merged
pstjohn
merged 6 commits into
NVIDIA:main
from
pstjohn:pstjohn/main/pyg-docker-build-caching
Oct 2, 2024
Merged
install geometric dependencies before invalidating caches with source copy #224
pstjohn
merged 6 commits into
NVIDIA:main
from
pstjohn:pstjohn/main/pyg-docker-build-caching
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstjohn
requested review from
DejunL,
guoqing-zhou,
jstjohn,
malcolmgreaves,
dorotat-nv,
jomitchellnv,
ohadmo and
trvachov
as code owners
October 1, 2024 20:33
pstjohn
force-pushed
the
pstjohn/main/pyg-docker-build-caching
branch
from
October 1, 2024 20:48
5f6cac4
to
90acb38
Compare
DejunL
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unfamiliar with the docker image caching mechanism involved here. @pstjohn do you mind explaining? Otherwise I trust you that this works
pstjohn
commented
Oct 1, 2024
ohadmo
approved these changes
Oct 1, 2024
jstjohn
approved these changes
Oct 1, 2024
ohadmo
reviewed
Oct 2, 2024
/build-ci |
tshimko-nv
pushed a commit
that referenced
this pull request
Oct 2, 2024
… copy (#224) * install geometric dependencies before invalidating caches with source code copy * add requirements-cve to docker build * expand dockerignore * update requirements-cve * add jupyter server cve * add comment for jupyter-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the install of these torch-scatter and torch-sparse dependencies higher in the docker build to avoid having to rebuild them from source if they're not cached