Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install geometric dependencies before invalidating caches with source copy #224

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Oct 1, 2024

Moves the install of these torch-scatter and torch-sparse dependencies higher in the docker build to avoid having to rebuild them from source if they're not cached

@pstjohn pstjohn force-pushed the pstjohn/main/pyg-docker-build-caching branch from 5f6cac4 to 90acb38 Compare October 1, 2024 20:48
Copy link
Collaborator

@DejunL DejunL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with the docker image caching mechanism involved here. @pstjohn do you mind explaining? Otherwise I trust you that this works

@pstjohn pstjohn self-assigned this Oct 1, 2024
Dockerfile Show resolved Hide resolved
@pstjohn
Copy link
Collaborator Author

pstjohn commented Oct 2, 2024

/build-ci

@pstjohn pstjohn enabled auto-merge (squash) October 2, 2024 02:20
@pstjohn pstjohn merged commit 19f32ba into NVIDIA:main Oct 2, 2024
3 checks passed
tshimko-nv pushed a commit that referenced this pull request Oct 2, 2024
… copy (#224)

* install geometric dependencies before invalidating caches with source code copy

* add requirements-cve to docker build

* expand dockerignore

* update requirements-cve

* add jupyter server cve

* add comment for jupyter-server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants