Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the removed bionemo-core sub-package #25

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Add back the removed bionemo-core sub-package #25

merged 2 commits into from
Jul 26, 2024

Conversation

malcolmgreaves
Copy link
Collaborator

No description provided.

@malcolmgreaves malcolmgreaves self-assigned this Jul 22, 2024
@malcolmgreaves
Copy link
Collaborator Author

/build-ci

@malcolmgreaves
Copy link
Collaborator Author

CI is currently blocked due to a failure. Context is here: https://nvidia.slack.com/archives/C074Z808N05/p1721936917048509?thread_ts=1721859387.508719&cid=C074Z808N05

@ohadmo
Copy link
Member

ohadmo commented Jul 26, 2024

CI is currently blocked due to a failure. Context is here: https://nvidia.slack.com/archives/C074Z808N05/p1721936917048509?thread_ts=1721859387.508719&cid=C074Z808N05

@malcolmgreaves, this is a format-check error:
https://prod.blsm.nvidia.com/bionemo-external-bionemo-fw/job/format_license_check/107/console

the header you added does not match:
https://github.com/NVIDIA/bionemo-fw-ea/blob/v2-main/license_header

@malcolmgreaves
Copy link
Collaborator Author

malcolmgreaves commented Jul 26, 2024 •
edited
Loading

Looks like there was a change to the CI that fixed my first issue. (The slack thread has more details if you care for more context: it was related to a wrong nemo version.) Thanks for pointing out this new second issue Ohad!

@malcolmgreaves
Copy link
Collaborator Author

/build-ci

@malcolmgreaves malcolmgreaves merged commit 7cf284e into v2-main Jul 26, 2024
2 checks passed
@malcolmgreaves malcolmgreaves deleted the mg/fix_core branch July 26, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstjohn pstjohn pstjohn approved these changes

@jstjohn jstjohn jstjohn approved these changes

@jomitchellnv jomitchellnv Awaiting requested review from jomitchellnv

Assignees

@malcolmgreaves malcolmgreaves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malcolmgreaves @ohadmo @jstjohn @pstjohn