Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pinned versions of bionemo dependencies #36

Closed
wants to merge 1 commit into from

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Jul 24, 2024

Addresses #29.

The following test is currently failing for me:

FAILED sub-packages/bionemo-contrib/tests/bionemo/contrib/model/biobert/test_model.py::test_geneformer_nemo1_v_nemo2_inference_golden_values - AttributeError: 'MegatronStrategy' object has no attribute 'trainer'

@pstjohn pstjohn self-assigned this Jul 24, 2024
@pstjohn pstjohn requested a review from jstjohn July 24, 2024 19:02
@pstjohn
Copy link
Collaborator Author

pstjohn commented Jul 24, 2024

/build-ci

1 similar comment
@ohadmo
Copy link
Member

ohadmo commented Jul 24, 2024

/build-ci

@pstjohn
Copy link
Collaborator Author

pstjohn commented Jul 24, 2024

closing in favor of #36

@pstjohn pstjohn closed this Jul 24, 2024
jstjohn added a commit that referenced this pull request Jul 25, 2024
)

* Update dependency tags to match PR #36, and try to fix test failure

* fix movement of global microbatches from apex to megatron
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants