Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test checkpoint IO loss is close to expected. #37

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

jstjohn
Copy link
Collaborator

@jstjohn jstjohn commented Jul 24, 2024

Test that when loading a checkpoint and applying to a real problem that we are not degrading our performance.

@jstjohn jstjohn self-assigned this Jul 24, 2024
@jstjohn
Copy link
Collaborator Author

jstjohn commented Jul 24, 2024

/build-ci

Copy link
Collaborator

@malcolmgreaves malcolmgreaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion to avoid a potential undefined variable exception.

@jstjohn
Copy link
Collaborator Author

jstjohn commented Jul 24, 2024

/build-ci

Copy link
Collaborator

@farhadrgh farhadrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jstjohn jstjohn force-pushed the jstjohn/inference-test-loss branch from 2f8da94 to 1b57d0a Compare July 25, 2024 22:10
@jstjohn
Copy link
Collaborator Author

jstjohn commented Jul 25, 2024

/build-ci

@jstjohn jstjohn enabled auto-merge (squash) July 25, 2024 22:11
@jstjohn jstjohn merged commit 215ac2b into v2-main Jul 25, 2024
1 check passed
@pstjohn pstjohn deleted the jstjohn/inference-test-loss branch January 17, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants