Make artifact downloads more robust #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build-ci |
pstjohn
force-pushed
the
pstjohn/v2-main/check_md5_sum
branch
from
cb8fb15 to
baf360e
Compare
|
/build-ci |
malcolmgreaves
approved these changes
Jul 25, 2024
| """ | ||
| md5 = hashlib.md5() | ||
| with open(file_path, "rb") as f: | ||
| for chunk in iter(lambda: f.read(4096), b""): |
There was a problem hiding this comment.
github copilot 😄 , I can't take too much credit
|
/build-ci |
pstjohn
force-pushed
the
pstjohn/v2-main/check_md5_sum
branch
from
a53e27b to
52b2aa4
Compare
|
/build-ci |
jstjohn
approved these changes
Jul 25, 2024
ohadmo
approved these changes
Jul 25, 2024
|
/build-ci |
pstjohn
force-pushed
the
pstjohn/v2-main/check_md5_sum
branch
from
52b2aa4 to
d472143
Compare
Adds md5sum checks and retries to downloads to hopefully prevent CI failures on malformed downloads.
Co-authored-by: Malcolm Greaves <[email protected]>
pstjohn
force-pushed
the
pstjohn/v2-main/check_md5_sum
branch
from
d472143 to
443ae93
Compare
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds md5sum checks and retries to downloads to hopefully prevent CI failures on malformed downloads.