update collate mask_value #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstjohn
requested review from
farhadrgh,
dorotat-nv,
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
|
/build-ci |
farhadrgh
approved these changes
Nov 27, 2024
pstjohn
force-pushed
the
pstjohn/collate-mask-value
branch
from
5e85de1 to
872700f
Compare
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a mask value of -100 elsewhere for these masked tokens, so we should be consistent in the collate function. This will be especially important if we use torchmetrics, which only wants a single value to ignore (rather than all negative values)